Use open3 for shell command execution #1
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the the run method takes the filename input and interpolates it into a backtick shell command without validating the filename. This can result in a code execution vulnerability should users of this wrapper not validate the filename (which could come from an untrusted source).
See this article for more information (https://www.hilman.io/blog/2016/01/stop-using-backtick-to-run-shell-command-in-ruby/)
This PR uses the Open3 standard library to execute the command which will make sure that the parameters to the
soxi
are properly escaped. It also adds some error handling should thesoxi
binary return an error.