Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing peer dependency in @nova-odm/annotations #9

Open
kiesel opened this issue Aug 3, 2023 · 2 comments
Open

Missing peer dependency in @nova-odm/annotations #9

kiesel opened this issue Aug 3, 2023 · 2 comments

Comments

@kiesel
Copy link

kiesel commented Aug 3, 2023

Hi,

while attempting to include these libaries in a project with yarn2, the following error occurred:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ @nova-odm/annotations@npm:0.8.7::__archiveUrl=[...]2Fnpm%2Fnpm%2F%40nova- \
odm%2Fannotations%2F-%2Fannotations-0.8.7.tgz doesn't provide @aws-sdk/client-dynamodb (p1924d), \
 requested by @nova-odm/auto-marshaller
[...]

Comparing the annotations package with the other ones, it seems the peer dependency to @aws-sdk/client-dynamodb is missing.

Best regards,
Alex

@ArsenyYankovsky
Copy link
Owner

Hi,

It's easy to add it but the annotations package doesn't use anything from the @aws-sdk/client-dynamodb so that's why it doesn't have it as a peer dependency. Let me know if I need to fix this or if you managed to somehow solve this. Thanks!

@kiesel
Copy link
Author

kiesel commented Sep 12, 2023

I am using yarn which complains about it with this message:

➤ YN0002: │ @nova-odm/annotations@npm:0.8.7 doesn't provide @aws-sdk/client-dynamodb (p1924d), requested by @nova-odm/auto-marshaller

Yarn (2+) warns about missing dependency links (see here some related information); since the annotation package depends on other packages that have a peer dependency on the client-dynamodb package, but annotations does not list it, it regards this as a amissing dependency. By including the peer dependency, you'd essentially handing the requirement outwards in the chain.

In this specific case, a problem would probably never really manifest, since usually you'll be not only depending on the annotations package, but also on one of the dependencies as well. But it'd be nice to get rid of the warning :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants