Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WS route to get the running actions #96

Closed
johhnry opened this issue Dec 1, 2021 · 0 comments · Fixed by #165
Closed

Add WS route to get the running actions #96

johhnry opened this issue Dec 1, 2021 · 0 comments · Fixed by #165
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@johhnry
Copy link
Contributor

johhnry commented Dec 1, 2021

If the Socket server is disconnected while actions are running, it loses them when reconnecting and so the front-end.

Between the UI and SSS we have: /ui/getRunningActions which returns a dictionary of actions:

getRunningActions: WithCallback<
  ServerResponseWithData<{ [uuid: string]: Action }>
>;

then when the UI starts up, it sends that query to get the current running actions. In this case the either silex_client should send the actions to the SSS when reconnecting (we can use the reconnection event) or the other way around?

@johhnry johhnry added enhancement New feature or request good first issue Good for newcomers labels Dec 1, 2021
@Acedyn Acedyn linked a pull request Jan 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant