Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested function name changes #3

Closed
CharlesJenkins opened this issue Mar 3, 2017 · 1 comment
Closed

Suggested function name changes #3

CharlesJenkins opened this issue Mar 3, 2017 · 1 comment

Comments

@CharlesJenkins
Copy link

CharlesJenkins commented Mar 3, 2017

Something that has been prefixed or suffixed has had a prefix or suffix added to it. So I think those are bad names for trimming functions.

How about these four prototypes instead:

  func trimRight( keeping length: Int ) -> String
  func trimRight( removing length: Int ) -> String
  func trimLeft( keeping length: Int ) -> String
  func trimLeft( removing length: Int ) -> String
@ArtSabintsev
Copy link
Owner

Not a bad idea. I was planning on doing some refactoring of those functions anyway. I will consider your proposed names over the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants