Allow custom UserDefaults object, bug fixed #28
Conversation
sync(keys: keys) => sync(userDefaults: userDefaults, keys: keys)
|
Please cleanup all the whitespace issues. Makes it really hard to see the diff. It's probably space/tabs issue in your Xcode settings. I will review it afterwards. |
|
Hey, I trimmed whitespaces from blank lines with Xcode settings. Thanks for the tip! |
|
By the way, some lines with "///" or "/// - Parameters:" had an extra space in front of them, some didn't. I matched them anyways. Kinda satisfying. |
|
Alright, I need to think about a few things with respect to this PR, specifically with the fact that this is introducing a breaking API change and will involve some Was there an issue creating a new |
Not sure what exactly you mean. But I didn't create any new methods. I only added an optional parameter. However, you had two |
|
I think you should create a third sync method that calls down to the others after it does what it needs to do. Doing that makes it so the API doesn't have a breaking change. |
Added 3rd and 4th overloaded sync func, with a custom UserDefaults object as an optional parameter, rather than adding the optional parameter to the original functions.
|
Got it. I committed changes adding the 3rd and 4th overloaded On another note, I am curious, why did you have the variadic-argument |
|
To clarify though, the UserDefaults parameter was an optional parameter so, in my previous commit, one could still call the |
|
I haven't forgotten about this PR. I will look later this week. |
| } | ||
|
|
||
| /// A session-persisted variable to directly access all of the NSUbiquitousKeyValueStore elements. | ||
| private var zephyrRemoteStoreDictionary: [String: Any] { | ||
| return NSUbiquitousKeyValueStore.default.dictionaryRepresentation | ||
| } | ||
|
|
||
| //The UserDefaults object to sync with NSUbiquitousKeyValueStore/iCloud |
There was a problem hiding this comment.
Three / and spacing afterwards.
There was a problem hiding this comment.
Actually, I'll merge it in and make the change myself and release this as part of the Swift 4.1 release I'm about to cut.
Thanks!
|
Merged and release in v3.1.0. Thanks again! |
Added an optional parameter to Zephyr.sync(), taking a custom UserDefaults object and using that in place of always using the container-wide UserDefaults.standard.
Fixed bug resulting in UserDefaults.standard being used despite passing in a custom UserDefaults object to the variable-arguments sync() function (when no keys were passed in)