New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect title #185

Merged
merged 3 commits into from Nov 22, 2017

Conversation

2 participants
@wbison
Contributor

wbison commented Nov 21, 2017

Only first word should be cap'ed

wbison added some commits Nov 21, 2017

Incorrect title
Only first word cap'ed
@wbison

This comment has been minimized.

Show comment
Hide comment
@wbison

wbison Nov 21, 2017

Contributor

First pull request (and what a monumental one) - sorry if I messed up.

Contributor

wbison commented Nov 21, 2017

First pull request (and what a monumental one) - sorry if I messed up.

@ArtSabintsev

This comment has been minimized.

Show comment
Hide comment
@ArtSabintsev

ArtSabintsev Nov 21, 2017

Owner

no problem! Fix the tests, too! :)

Owner

ArtSabintsev commented Nov 21, 2017

no problem! Fix the tests, too! :)

Incorrect title
Only first word cap'ed
@wbison

This comment has been minimized.

Show comment
Hide comment
@wbison

wbison Nov 21, 2017

Contributor

hmm - the new commit was automagically added to the existing pr? I have to study this PR stuff.

Have I just started my career as Open Source Developer?

Contributor

wbison commented Nov 21, 2017

hmm - the new commit was automagically added to the existing pr? I have to study this PR stuff.

Have I just started my career as Open Source Developer?

@ArtSabintsev

This comment has been minimized.

Show comment
Hide comment
@ArtSabintsev

ArtSabintsev Nov 22, 2017

Owner

Yes you have! Thanks for your contribution!

Owner

ArtSabintsev commented Nov 22, 2017

Yes you have! Thanks for your contribution!

@ArtSabintsev ArtSabintsev merged commit b08738a into ArtSabintsev:master Nov 22, 2017

1 check passed

buddybuild: Harpy (iOS, HarpyExample - Debug) Build succeeded
Details
@ArtSabintsev

This comment has been minimized.

Show comment
Hide comment
@ArtSabintsev

ArtSabintsev Nov 22, 2017

Owner

Added this fix to the Swift version as well: https://github.com/ArtSabintsev/Siren/releases/tag/3.1.7

Owner

ArtSabintsev commented Nov 22, 2017

Added this fix to the Swift version as well: https://github.com/ArtSabintsev/Siren/releases/tag/3.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment