refactor(ui/conf): better handling of mutable config #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default configuration
Signed-off-by: Frost Ming <me@frostming.com>
This was referenced Dec 25, 2023
syfxlin
approved these changes
Dec 26, 2023
|
已经验证过，可以正常使用🎉 |
ヾ(≧∇≦*)ゝ |
qwqcode
added a commit
that referenced
this pull request
Dec 26, 2023
* fix(ui): mergeDeep causes some configurations to be overridden by the default configuration * fix: config always get override by defaults Signed-off-by: Frost Ming <me@frostming.com> * refactor(ui/conf): better handling of mutable config * chore: fix path issue on win env * fix: mergeDeep avoid prototype pollution BREAKING CHANGE: Directly referencing `artalk.conf` and `artalk.$root` is deprecated. Please use functions instead: `artalk.getConf()` and `artalk.getEl()`. --------- Signed-off-by: Frost Ming <me@frostming.com> Co-authored-by: syfxlin <i@ixk.me> Co-authored-by: Frost Ming <me@frostming.com>
|
太感谢了，下个版本发布时间有大概计划吗 |
|
刚刚修完一些其他的 BUG，新版 v2.7.3 已发布 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
artalk.init、artalk.updateConf等操作的单元测试mergeDeep函数为创建新对象（immutable）, 而不再是 in-place 作用于原始对象（不再修改调用函数时传入的对象）getConf、getEl函数，同时弃用artalk.conf、artalk.$rootClose #720
Close #719
Close #718