perf(conf/upgit): disallow custom executable path of upgit for security
#817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity BREAKING CHANGE: For UpGit users: Due to security reasons, Artalk no longer allows specifying the executable file path for UpGit (`img_upload.upgit.exec`). Please add it to the system's environment variables instead.
qwqcode
commented
Apr 7, 2024
| cmdStrSplitted := strings.Split(execCommand, " ") | ||
| execApp := cmdStrSplitted[0] |
There was a problem hiding this comment.
An attacker may modify the configuration file and enter rm -rf /* if Artalk gives high permissions. So remove it!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 27.20% 27.12% -0.09%
==========================================
Files 181 181
Lines 6972 6972
==========================================
- Hits 1897 1891 -6
- Misses 4963 4967 +4
- Partials 112 114 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: For UpGit users: Due to security reasons, Artalk no longer allows configuring the executable file path (img_upload.upgit.exec) for upgit. Please add it to system environment variables instead.