New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::codecvt_utf8 is deprecated since C++17 #264

Open

shleym2000 opened this issue Feb 18, 2023 · 1 comment

Labels

@todo type:build/install

Contributor

shleym2000 commented Feb 18, 2023

Code uses the templated function std::codecvt_utf8, which has an implicit template parameter std::codecvt_mode

In fact the entire header is deprecated per https://isocpp.org/files/papers/p0636r0.html :

"P0618R0 - Deprecate - The entire header (which does not contain the class codecvt!) is deprecated, as are the utilities wstring_convert and wbuffer_convert. These features are hard to use correctly, and there are doubts whether they are even specified correctly. Users should use dedicated text-processing libraries instead."

As the result, library can not be compiled without suppressing some compiler's errors

davidge807 added @todo type:build/install labels

Contributor Author

shleym2000 commented Mar 29, 2024 •

edited

Please, consider reviewing and merging my pull request ( #303 )

It solves the issue and OpenNN library would be able to advance to at least C++17 standards.

shleym2000 mentioned this issue

Bringing attention to Pull Request, which solves TODO issue #304

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment