Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop Bug] Color Picker Previews in Style Settings Not Holding Colors #72

Open
SuperDragonite2172 opened this issue Feb 19, 2024 · 4 comments

Comments

@SuperDragonite2172
Copy link

SuperDragonite2172 commented Feb 19, 2024

Describe the bug
When editing the colors in the Color Picker dropdown in Style Settings, the color previews don't hold their color after closing and re-opening Style Settings. They all default to the hsla(170, 49%, 32%, 1) regardless of what they're actually set to.

To Reproduce
Steps to reproduce the behavior:

  1. Open Style Settings in Options
  2. Change a color or apply the default
  3. Close the dropdown or options
  4. Observe the new colors taking effect
  5. Reopen the settings to find the colors preview "unchanged".

Expected behavior
Color previews in Style Settings display the actual color not the default.

Screenshots, Gifs, Video
2024-02-18_1708302823
2024-02-18_1708302885

Desktop (please complete the following information):

  • OS: Windows 11 Pro
  • Obsidian Version 1.5.3
  • CyberGlow Version 8.2.5

Additional context
The example screenshots show the headings specifically since they're the most obvious, but it applies to all the colors.
Originally I thought the colors weren't applying correctly at all but in filing the issue I discovered it was just Style Settings not updating correctly. Apologies if there's any weirdness in the information provided as a result.
Edit: It just occurred to me this might be an upstream issue with Style Settings rather than with the theme specifically. I don't have any other themes that utilize Style Settings so I can't verify.

@SuperDragonite2172 SuperDragonite2172 added the Desktop Bug Bug on Desktop label Feb 19, 2024
@ArtexJay
Copy link
Owner

ArtexJay commented Feb 22, 2024

I am unable to reproduce this issue with default theme colors after I applied custom colors via Style Settings, I have closed style settings and even restarted Obsidian, with Style Setting still showing the correct saved color for headings when altered.
Do they default to that hsla(170, 49%, 32%, 1) even with the default theme colors for you?

If you have modified my theme, backup the theme file so you don't lose your custom edits and redownload my theme, see if the issue persists.

@SuperDragonite2172
Copy link
Author

I uninstalled Cyber Glow and Style Settings, then re-installed both. I also updated Cyber Glow to 8.2.6. The issue persists and the displayed colors are still not correct until I reset them or click on the color to change it. Thankfully the only settings I really change are enabling the workspace background and hovering the status bar.

@ArtexJay
Copy link
Owner

that's very strange, I tried again today, but I cannot replicate this on my end, the colors display correct custom applied colors.
image

This could be a Style Settings issue, but I really do not know.

My installer version is 1.5.3, with Obsidian at version 1.5.8, I'm assuming it's the same with you.

@SuperDragonite2172
Copy link
Author

I was on Obsidian 1.5.3. I just updated it to 1.5.8 and the issue still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants