Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Things we need; #4

Closed
asxlvm opened this issue Mar 24, 2021 · 16 comments
Closed

Things we need; #4

asxlvm opened this issue Mar 24, 2021 · 16 comments
Assignees
Labels
enhancement New feature or request

Comments

@asxlvm
Copy link

asxlvm commented Mar 24, 2021

So, I'm new to Github and I don't know where to type comments so I'll issue it.
The things we need the most;

  1. A documentation for the module! I had to look through the source code to find what I need
  2. Functions that can do these things: "Make Mod", "Make Room Admin", "Ban from Chat", "Ban from Room"
@Arthurdw
Copy link
Owner

Yeah, I'll implement those later. Documentation will also be added later.

@Arthurdw Arthurdw self-assigned this Mar 24, 2021
@Arthurdw Arthurdw added the enhancement New feature or request label Mar 24, 2021
@asxlvm
Copy link
Author

asxlvm commented Mar 24, 2021

Okay! Though thank you so much for making this module, you made everything easier <3

@Arthurdw
Copy link
Owner

Arthurdw commented Mar 24, 2021

Features:

  • Ask to speak
  • Make mod
  • Make room admin
  • Ban from room
  • Ban from room chat
  • Remove message
  • Umod
  • Unban
  • Go back to listener
  • Set other user to listener
  • Add speaker
  • On speaker removed
  • On chat user banned
  • On message deleted
  • On speaker request

I'll be trying to implement these first.

@asxlvm
Copy link
Author

asxlvm commented Mar 24, 2021

The checkmarked features are already done or the ones you're working at?

@Arthurdw
Copy link
Owner

The checkmarked features are already done or the ones you're working at?

The one's done, I just pushed them to the repo.
They aren't included yet, I'll create a new release when I've added the last 3 event listeners.

Tomorrow I'll look into Sphinx documentation or smth.

@asxlvm
Copy link
Author

asxlvm commented Mar 24, 2021

Okayy, but good job on this stuff, you're doing great!

@Arthurdw
Copy link
Owner

I released the new package with those features.

@asxlvm
Copy link
Author

asxlvm commented Mar 25, 2021

Hey! Don't wanna be annoying but, do we have a wait_for event? Would really help having it!

@Arthurdw
Copy link
Owner

I'll add it to the todo list.

@Arthurdw
Copy link
Owner

I implemented the wait_for event.

@asxlvm
Copy link
Author

asxlvm commented Mar 26, 2021

We need a way to make easy-to-do cooldowns for commands, and also, is there a isMod? and isAdmin? check?

@Arthurdw
Copy link
Owner

Great idea's. I'be added these to the todo-list. I'm going to learn how I can create convertors in python first tho.

@Arthurdw
Copy link
Owner

Commands, command aliases & command cooldowns have been implemented.
The is_mod & is_admin attributes can be found in the User object its room_permissions parameter. (Which is a Permissions object)

@asxlvm
Copy link
Author

asxlvm commented Mar 30, 2021

We need a fetch_user function (if it's possible with the API) so we can get usernames form the user ID :D

@Arthurdw
Copy link
Owner

Yeah, that was in the planning, that function is already in place in 1.3.0 but it hasn't implemented the API fetch yet. (Now it looks through the cache to find a user.)

@Arthurdw
Copy link
Owner

After a lot of time, we are finally able to close this issue.

You are now able to fetch a user. See the example

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants