Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/user #29

Merged
merged 16 commits into from
May 7, 2022
Merged

Feature/user #29

merged 16 commits into from
May 7, 2022

Conversation

Ashsenior
Copy link

@Ashsenior Ashsenior commented Mar 17, 2022

Related Issues or bug

  • Create a Login & Signup form .

Fixes: #27

Proposed Changes

  • Created Login , Signup and Verification components and backend . Improved little bit of UI.

Additional Info

  • Anything related Issues

Screenshots

Original Updated
original screenshot updated screenshot
Screenshot (66)
Screenshot (67)
![Screenshot (68)](https://user-images.githubusercontent.c
Screenshot (69)
om/49332381/158767284-1bc22b88-53b9-41cb-9820-38a949b7ff6a.png)

Copy link
Owner

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ashsenior Nice work 👏

but I'm not able to signup:
Could you confirm this from your end?

at backend

Forbidden: /api/create-user/
[17/Mar/2022 08:55:05] "POST /api/create-user/ HTTP/1.1" 403 58

Screenshot from 2022-03-17 14-25-09

@Ashsenior
Copy link
Author

Ashsenior commented Mar 17, 2022

Thnx for the appreciation

I guess it's an error caused because i didn't add csrf_token . Try now

And it is working totally fine in my desktop .

@Ashsenior
Copy link
Author

Ashsenior commented Mar 22, 2022

Any problem ?? @Aryamanz29

@Ashsenior
Copy link
Author

Hey @Aryamanz29 how do I solve the code formatting issue ?

@HemantSachdeva
Copy link
Collaborator

Hey @Aryamanz29 how do I solve the code formatting issue ?

Download flake8 python library using pip and format the code, commit and push it.

@HemantSachdeva
Copy link
Collaborator

@Aryamanz29 Why do we have black and flake both checks? 🤔

@Ashsenior
Copy link
Author

@Aryamanz29 Why do we have black and flake both checks? 🤔

Do i remove the black-check code ?

@HemantSachdeva
Copy link
Collaborator

@Aryamanz29 Why do we have black and flake both checks? thinking

Do i remove the black-check code ?

Amm your choice, it just focus on single/double quotes and formats a dictionary in a single line (awful imo). That's all what I've observed about the black linting.

@Ashsenior
Copy link
Author

Ashsenior commented May 6, 2022

can you please merge it now ?
and please add the level3 and GSSoC22 tag because gssoc system doesnt recognizes it otherwise
@Aryamanz29

@Aryamanz29 Aryamanz29 added enhancement New feature or request GSSoC22 Counts towards GSSoC22 contribution Level3 Level - Hard (GSSoC22) labels May 7, 2022
@Aryamanz29
Copy link
Owner

can you please merge it now ? and please add the level3 and GSSoC22 tag because gssoc system doesnt recognizes it otherwise @Aryamanz29

I'm really sorry. I'm too busy with my other commitments. Last time I've reviewed your PR's it looks good to me, but I guess when running a search on logs after uploading it doesn't show me expected results. I'll test it again and let you know 👍
Right now, I'm merging your work to develop branch and also added appropriate issue labels to so that it will count towards your contribution 👍

@Aryamanz29
Copy link
Owner

@Aryamanz29 Why do we have black and flake both checks? thinking

We're using Flake8 for ensuring code follows PEP 8 standard & Black for code formatting.

@Aryamanz29 Aryamanz29 changed the base branch from master to develop May 7, 2022 11:57
@Aryamanz29 Aryamanz29 merged commit 56cef8b into Aryamanz29:develop May 7, 2022
@Aryamanz29
Copy link
Owner

@Ashsenior Thanks for your contribution 🎉 & @HemantSachdeva For helping him out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GSSoC22 Counts towards GSSoC22 contribution Level3 Level - Hard (GSSoC22)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Create a user Login & Signup
3 participants