You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When sending a client packet to the server with an missing messagepack key that the server expects the entire server crashes.
Version Encountered
Development branch
To Reproduce
Steps to reproduce the behavior:
Compile a server.
Remove a random element from any packet.
Compile client and run this client versus the server, server crashes when the packet is sent from the client.
Expected behavior
The user should be disconnected from the server, rather than taking the entire server down upon such an error.
Screenshots
If applicable, add screenshots to help explain your problem.
Logs 2021-03-11 18:25:01.781 [Error] Message: Failed to deserialize Intersect.Network.Packets.Client.NationQueryPacket value. Stack: at MessagePack.MessagePackSerializer.Deserialize[T](MessagePackReader& reader, MessagePackSerializerOptions options) at MessagePack.MessagePackSerializer.Deserialize[T](ReadOnlyMemory1 buffer, MessagePackSerializerOptions options, CancellationToken cancellationToken)
at lambda_method(Closure , ReadOnlyMemory1 , MessagePackSerializerOptions , CancellationToken ) at MessagePack.MessagePackSerializer.Deserialize(Type type, ReadOnlyMemory1 bytes, MessagePackSerializerOptions options, CancellationToken cancellationToken)
at Intersect.Network.MessagePacker.Deserialize(Byte[] data) in C:\Projects\Intersect-Leafling\Intersect (Core)\Network\MessagePacker.cs:line 44
Caused By
Message: Unexpected msgpack code 196 (bin 8) encountered.
Stack: at MessagePack.MessagePackReader.ThrowInvalidCode(Byte code)
at MessagePack.MessagePackReader.ReadInt32()
at MessagePack.Formatters.Intersect_Network_Packets_Client_NationQueryPacketFormatter48.Deserialize(MessagePackReader& reader, MessagePackSerializerOptions options)
at MessagePack.MessagePackSerializer.Deserialize[T](MessagePackReader& reader, MessagePackSerializerOptions options)
2021-03-11 18:25:01.789 [Error] Received unhandled exception from Name:Intersect Server.exe
There are no context policies.
.
2021-03-11 18:25:01.789 [Error]
Message: Object reference not set to an instance of an object.
Stack: at Intersect.Server.Networking.PacketHandler.HandlePacket(IConnection connection, IPacket packet) in C:\Projects\Intersect-Leafling\Intersect.Server\Networking\PacketHandler.cs:line 145
at Intersect.Network.AbstractNetwork.HandleInboundData(IBuffer buffer, IConnection connection) in C:\Projects\Intersect-Leafling\Intersect (Core)\Network\AbstractNetwork.cs:line 240
at Intersect.Network.AbstractNetwork.HandleInboundMessageAvailable(INetworkLayerInterface sender) in C:\Projects\Intersect-Leafling\Intersect (Core)\Network\AbstractNetwork.cs:line 184
at Intersect.Network.Lidgren.LidgrenInterface.<.ctor>b__9_0(Object peer) in C:\Projects\Intersect-Leafling\Intersect.Network\Lidgren\LidgrenInterface.cs:line 133
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()`
Operating System:
Windows, Mac, Or Linux
Additional context
Packet names in log do not exist in Intersect, but I would imagine the issue is much the same for other packets.
Could potentially have script kiddies crashing game servers with malformed packets.
The text was updated successfully, but these errors were encountered:
Describe the bug
When sending a client packet to the server with an missing messagepack key that the server expects the entire server crashes.
Version Encountered
Development branch
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The user should be disconnected from the server, rather than taking the entire server down upon such an error.
Screenshots
If applicable, add screenshots to help explain your problem.
Logs
2021-03-11 18:25:01.781 [Error] Message: Failed to deserialize Intersect.Network.Packets.Client.NationQueryPacket value. Stack: at MessagePack.MessagePackSerializer.Deserialize[T](MessagePackReader& reader, MessagePackSerializerOptions options) at MessagePack.MessagePackSerializer.Deserialize[T](ReadOnlyMemory
1 buffer, MessagePackSerializerOptions options, CancellationToken cancellationToken)at lambda_method(Closure , ReadOnlyMemory
1 , MessagePackSerializerOptions , CancellationToken ) at MessagePack.MessagePackSerializer.Deserialize(Type type, ReadOnlyMemory
1 bytes, MessagePackSerializerOptions options, CancellationToken cancellationToken)at Intersect.Network.MessagePacker.Deserialize(Byte[] data) in C:\Projects\Intersect-Leafling\Intersect (Core)\Network\MessagePacker.cs:line 44
Caused By
Message: Unexpected msgpack code 196 (bin 8) encountered.
Stack: at MessagePack.MessagePackReader.ThrowInvalidCode(Byte code)
at MessagePack.MessagePackReader.ReadInt32()
at MessagePack.Formatters.Intersect_Network_Packets_Client_NationQueryPacketFormatter48.Deserialize(MessagePackReader& reader, MessagePackSerializerOptions options)
at MessagePack.MessagePackSerializer.Deserialize[T](MessagePackReader& reader, MessagePackSerializerOptions options)
2021-03-11 18:25:01.789 [Error] Received unhandled exception from Name:Intersect Server.exe
There are no context policies.
.
2021-03-11 18:25:01.789 [Error]
Message: Object reference not set to an instance of an object.
Stack: at Intersect.Server.Networking.PacketHandler.HandlePacket(IConnection connection, IPacket packet) in C:\Projects\Intersect-Leafling\Intersect.Server\Networking\PacketHandler.cs:line 145
at Intersect.Network.AbstractNetwork.HandleInboundData(IBuffer buffer, IConnection connection) in C:\Projects\Intersect-Leafling\Intersect (Core)\Network\AbstractNetwork.cs:line 240
at Intersect.Network.AbstractNetwork.HandleInboundMessageAvailable(INetworkLayerInterface sender) in C:\Projects\Intersect-Leafling\Intersect (Core)\Network\AbstractNetwork.cs:line 184
at Intersect.Network.Lidgren.LidgrenInterface.<.ctor>b__9_0(Object peer) in C:\Projects\Intersect-Leafling\Intersect.Network\Lidgren\LidgrenInterface.cs:line 133
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()`
Operating System:
Windows, Mac, Or Linux
Additional context
Packet names in log do not exist in Intersect, but I would imagine the issue is much the same for other packets.
Could potentially have script kiddies crashing game servers with malformed packets.
The text was updated successfully, but these errors were encountered: