Validation period start/end time generation doesn't work on MacOS

[Nuttymoon]

When adding a validator to a Subnet, we use date to generate subnet_validator_start_time and subnet_validator_end_time:

ansible-avalanche-collection/roles/node/defaults/main.yml

Lines 105 to 106 in 9c22fe7

	subnet_validator_start_time: '{{ lookup("pipe", "date -d ''2 minutes'' --rfc-3339=seconds").replace(" ", "T") }}' # in 2 minutes
	subnet_validator_end_time: '{{ lookup("pipe", "date -d ''1 week'' --rfc-3339=seconds").replace(" ", "T") }}' # in 1 week

ansible-avalanche-collection/roles/subnet/defaults/main.yml

Lines 65 to 66 in 9c22fe7

	subnet_validator_start_time: '{{ lookup("pipe", "date -d ''2 minutes'' --rfc-3339=seconds").replace(" ", "T") }}' # in 2 minutes
	subnet_validator_end_time: '{{ lookup("pipe", "date -d ''1 week'' --rfc-3339=seconds").replace(" ", "T") }}' # in 1 week

A user reported that the default command doesn't work on MacOS.

I see 2 solutions:

• If possible we can try to find a command that works both on Linux and MacOS.
• Otherwise, we can template the variable based on the current OS.

Help wanted: We don't have Macs at our disposal for testing, so we need a MacOS user to find the right date command to obtain a string in RFC 3339 format, e.g. 2023-06-20T11:28:28+02:00. Note that extra Jinja filters can be used to adapt the format (see replace() usage above).

[pedro-sys]

You can try with
subnet_validator_start_time: "{{ lookup('pipe', "date -v+2M '+%Y-%m-%dT%H:%M:%SZ'") }}"
subnet_validator_end_time: "{{ lookup('pipe', "date -v+1w '+%Y-%m-%dT%H:%M:%SZ'") }}"

[leopaul36]

You can try with subnet_validator_start_time: "{{ lookup('pipe', "date -v+2M '+%Y-%m-%dT%H:%M:%SZ'") }}" subnet_validator_end_time: "{{ lookup('pipe', "date -v+1w '+%Y-%m-%dT%H:%M:%SZ'") }}"

Unfortunately date -v+2M '+%Y-%m-%dT%H:%M:%SZ' does not seem to be working on Linux, I guess we will have to template a different command depending on the OS.

[Nuttymoon]

You can try with subnet_validator_start_time: "{{ lookup('pipe', "date -v+2M '+%Y-%m-%dT%H:%M:%SZ'") }}" subnet_validator_end_time: "{{ lookup('pipe', "date -v+1w '+%Y-%m-%dT%H:%M:%SZ'") }}"

Unfortunately date -v+2M '+%Y-%m-%dT%H:%M:%SZ' does not seem to be working on Linux, I guess we will have to template a different command depending on the OS.

Yes I think we can do that by using the os_family fact.

[leopaul36]

Implemented in #75

Would you be able to try this PR @pedro-sys ? Ansible should now pick the good MacOS command seamlessly.

[pedro-sys]

hello
It work perfectly !!

[leopaul36]

hello It work perfectly !!

Great! Thanks for testing @pedro-sys.

I'll let @Nuttymoon review and then merge to main