Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XML Markers] Add Code Generator for Enum Classes #69

Closed
Tracked by #64
AsherGlick opened this issue Jul 23, 2022 · 0 comments
Closed
Tracked by #64

[XML Markers] Add Code Generator for Enum Classes #69

AsherGlick opened this issue Jul 23, 2022 · 0 comments

Comments

@AsherGlick
Copy link
Owner

AsherGlick commented Jul 23, 2022

Enum classes do not exist in the prototype xml parser, an example of them would be Chirality.

Right now in the Cull documentation, which uses chirality as a type, there is no indication that the type is named "Chirality". Unlike filter types, it is possible for an enum type like this to be re-used. Possibly there should be a new field in the enum definition that says it should have a custom data type name and not be "Cull" but instead "Chirality". However currently Chirality is the only enum type so it might make sense to ditch this generator and convert Cull to a custom type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant