Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function signatures are not cached #20

Closed
Changaco opened this issue Oct 4, 2016 · 1 comment
Closed

Function signatures are not cached #20

Changaco opened this issue Oct 4, 2016 · 1 comment

Comments

@Changaco
Copy link
Member

Changaco commented Oct 4, 2016

That's not very good for performance. Upstream issue: AspenWeb/dependency_injection.py#6.
@Changaco
Copy link
Member Author

Changaco commented Feb 20, 2018 •
edited
Loading

I did some profiling of dependency_injection: when calling resolve_dependencies the sub-call to get_signature is ~60% of the work, so caching the signatures would really improve performance (although it wouldn't be noticeable under normal workloads).

@Changaco Changaco mentioned this issue Jun 17, 2018
Merged
@Changaco Changaco mentioned this issue Nov 19, 2018
Merged
@Changaco Changaco mentioned this issue Feb 11, 2019
Merged
@Changaco Changaco mentioned this issue Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Changaco