New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed addressable gem #20
Conversation
Hmm, The Travis build failed in weird place. Only for 1.9.3 and I can't reproduce this locally. I think this TimeCop related issue. |
looks fine to me, I'll have a look at the build-issues before merging. Thanks for the patch. |
Also added Faraday integration test to avoid similar errors in the future.
After merging this pull request I get local build failures, but travis seems to indicate everything is fine. So use with caution. |
Hmm, tested locally on 1.9.3 and jruby without any issues. Where exactly tests fails? |
fails in the faraday integration test that you added. However, as I said it passes on travis just fine. The trace I get is
It's probably something with my local setup, but I thought it's good to advise caution. I'll roll this into a release once I figured out why it fails for me. |
Ok, it fails with an old version of faraday. I had 0.7.5 installed, an update to 0.8.4 fixes it. I assume that you're using a method that was only added later. |
pushed as 0.6.3 |
As you know addressable gem author drop support for nested params. So I use Rack::Utils.parse_nested_query instead.
This also fix #18