-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First proposal for editing DateTimePicker values #29
Draft
wolframhaussig
wants to merge
6
commits into
main
Choose a base branch
from
bug/24-bug-keyboard-control-behavior-of-the-stylabledatetimepicker-control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
First proposal for editing DateTimePicker values #29
wolframhaussig
wants to merge
6
commits into
main
from
bug/24-bug-keyboard-control-behavior-of-the-stylabledatetimepicker-control
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolframhaussig
force-pushed
the
bug/24-bug-keyboard-control-behavior-of-the-stylabledatetimepicker-control
branch
from
August 9, 2023 18:03
5d92f77
to
258bb62
Compare
wolframhaussig
force-pushed
the
bug/24-bug-keyboard-control-behavior-of-the-stylabledatetimepicker-control
branch
from
August 9, 2023 19:52
af2c50e
to
1753730
Compare
…not full day of week or month names)
Nockiro
reviewed
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the current approach, I do however see a bit of space for improvements:
- if we support keyboard input , we should support it in all aspects (-> WoD and month, too) to avoid confusion, imo
- the current spacing works fine for
Format=Long
, but not so well forFormat=Short
or evenFormat=Time
. We should probable use different spacing values for each of them.
…ontrol-behavior-of-the-stylabledatetimepicker-control # Conflicts: # StylableWinFormsControls/StylableWinFormsControls/Controls/StylableDateTimePicker.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24
TODO: