Update compile.ts - more clear Error message when using swanky contract compile #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunsukew
reviewed
Mar 17, 2023
| @@ -69,7 +69,7 @@ export class CompileContract extends Command { | |||
| for (const contractName of contractNames) { | |||
| const contractInfo = config.contracts[contractName]; | |||
| if (!contractInfo) { | |||
| this.error(`Cannot find contract info for ${contractName} contract in swanky.config.json`); | |||
| this.error(`Cannot find contract info for ${contractName} contract in swanky.config.json. If you are trying to compile all available contracts in the project, please use --all flag.`); | |||
There was a problem hiding this comment.
getting undefined here is trivial bug which I introduced in the last PR when resolving contracts.
So, when neither contract name nor --all flag specified, we gets error even before here. it will be fixed with this PR #126
There was a problem hiding this comment.
@shunsukew this one can be closed now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more verbosity to swanky contract compile when invoked without arguments (suggesting to use --all feature to compile all available cotracts).