New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use polkadot api #3
Conversation
@hoonsubin |
src/commands/account/list.ts
Outdated
this.log( | ||
`\t${yellowBright("Alias: ")} ${account.alias.padEnd( | ||
12 | ||
)} ${yellowBright("Mnemonic: ")} ${account.mnemonic}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to log the mnemonic to the console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about how it shouldn't be in the in the config neither, that's why there's a warning to only store dev accounts, and this is output only with --verbose flag.
It's useful for example when you want to add those to polkadot.js app to transfer some tokens to it.
That being said, I agree, we can't trust the user not to use those in prod. I'll remove the option for now and think about how to actually prevent using stored accounts for prod deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
cargo contract
in deploy command in favour of polkadot.js api callsChainApi
class to handle api interactionDeployApi
subclass with methods specific to deploymentlistr
sequence to deploy commandTODO: