Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink name #41

Open
jonathansimmons opened this issue Jul 17, 2015 · 3 comments
Open

Rethink name #41

jonathansimmons opened this issue Jul 17, 2015 · 3 comments

Comments

@jonathansimmons
Copy link

The name of this gem implies that it is somehow related to "Google Authenticator". When in reality it simply allows "Two Factor Support" in devise.

When searching for a gem to help us implement two factor with devise, yours was off my radar because I wanted support for something more than just "Google authenticator". There are many 2 factor apps for both Android and iOS at this point and we don't want our users locked into one app

There is already https://github.com/tinfoil/devise-two-factor. The advantage you have over them is that you've worked out the second step a good bit of people are looking for. devise-two-factor/devise-two-factor#14

I recommend changing the name of this gem to "devise_two_factor" or "devise_two_factor_athentication" You'll surely see an increase in usage and contribution.

@vrogers
Copy link

vrogers commented Aug 17, 2015

I agree with this, because I almost used another tool until I saw this "issue".

@jonathansimmons
Copy link
Author

@vrogers you might also look at https://github.com/wmlele/devise-otp. I put some time into that and it's a touch more recently updated. I found it to better suit my needs.

@vrogers
Copy link

vrogers commented Aug 17, 2015

I like it! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants