Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the MR-GNN model #12

Closed
benedekrozemberczki opened this issue Jan 11, 2022 · 4 comments · Fixed by #82
Closed

Add the MR-GNN model #12

benedekrozemberczki opened this issue Jan 11, 2022 · 4 comments · Fixed by #82
Assignees
Labels

Comments

@benedekrozemberczki
Copy link
Contributor

benedekrozemberczki commented Jan 11, 2022

Dear @cthoyt,

  • Please read the paper first. It is here.
  • There is also code-release with the paper here.
  • After that read the contributing guidelines.
  • If there is an existing open-source version of the model please take a look.
  • ChemicalX is built on top of PyTorch 1.10. and torchdrug.
  • The library heavily builds on top on torchdrug and molecules in batches are PackedGraphs.
  • There is already a model class under ./chemicalx/models/
  • Context features, drug level features, and labels are all FloatTensors.
  • Look at the examples and tests under ./examples/ and ./tests/.
  • Add auxiliary layers as you see fit - please document these, add tests, and add these layers to the main readme.md if needed.
  • Add typing to the initialization and forward pass.
  • Non-data-dependent hyper-ammeters should have default values.
  • Please add tests under ./tests/ and make sure that your model/layer is tested with real data.
  • Write an example under ./examples/. What is the AUC on the test set? Is it reasonable?
@benedekrozemberczki
Copy link
Contributor Author

Cannot assign you for some reason :S

@cthoyt
Copy link
Collaborator

cthoyt commented Jan 14, 2022

You have to add me as an external collaborator to the repo to make assignments

@benedekrozemberczki
Copy link
Contributor Author

The organization AZ does not allow that :S

@benedekrozemberczki
Copy link
Contributor Author

Super annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants