Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emissive Textures Support for Shaders #3

Closed
xdevilkillx opened this issue Dec 5, 2021 · 27 comments
Closed

Emissive Textures Support for Shaders #3

xdevilkillx opened this issue Dec 5, 2021 · 27 comments

Comments

@xdevilkillx
Copy link

Ores do not support Emissive Textures in Shaders (Shaders in pictures is Complementary Shaders)
2021-12-05_00 12 23
2021-12-05_00 12 42

@AstralOrdana
Copy link
Owner

If you can point me toward a resource that will show me how to add support for this then I will do my best to add it.

@xdevilkillx
Copy link
Author

This seems like it: Tutorial

@AstralOrdana
Copy link
Owner

so the shader will recognize a folder called optifine?

@AstralOrdana
Copy link
Owner

test the version I just pushed because I don't have my game setup to test emissive textures

@xdevilkillx
Copy link
Author

Taken from reddit:

"Long answer: An emissive texture overlays on top of any already existing in-world texture. So if you add a custom item texture (CIT) depending on the item's name, you can just make parts of that texture emissive by adding an emissive map for that item.

Example: My pack has a unique diamond_sword.png texture. I've added a custom variant for diamond swords when they're renamed to "Command Block Sword", which uses the command_block_sword.png texture in the CIT folder of my resource pack. That folder also contains a command_block_sword_emissive.png texture (where "_emissive" is specified in my pack's emissive.properties file), which applies an emissive map on top of the command_block_sword.png file - which only shows up when a diamond sword has a custom name."

So possibly just add the emissive texture to the same folder as the regular? I'm not sure.

@AstralOrdana
Copy link
Owner

yeah i figured that part out, i just don't have a way to quickly test it

@xdevilkillx
Copy link
Author

I can test it if you'd like. If all I need to do is install it.

@AstralOrdana
Copy link
Owner

wait, i need to push a fix first

@AstralOrdana
Copy link
Owner

go to mores/build/libs and take the mores-1.2.5.jar file and put it in your mods folder

@xdevilkillx
Copy link
Author

Sorry, I'm having trouble finding where that is.

@AstralOrdana
Copy link
Owner

the folder called build inside the main folder of the repository

@xdevilkillx
Copy link
Author

I do not see that, do you not have it public?
Capture

@AstralOrdana
Copy link
Owner

I have uploaded it to curseforge as a beta version, you can get it there

@xdevilkillx
Copy link
Author

xdevilkillx commented Dec 5, 2021

It is not working, though you did change it that the default redstone ores are not emissive unless glowing(mores redstone is not emissive though) Though I'd prefer if redstone is always emissive.
2021-12-05_14 10 40
2021-12-05_14 11 46

@xdevilkillx
Copy link
Author

To be fair I am also using Sodium+Iris Shaders and not Optifine, so I can try that in a sec.

@xdevilkillx
Copy link
Author

I seem to be crashing when loading into world with Optifabric, so I can't test Optifine.
Though I don't see a reason why it shouldn't work with Sodium+Iris Shaders. I could be wrong though.

@AstralOrdana
Copy link
Owner

does sodium + iris shaders use the optifine system for emissive textures?

@AstralOrdana
Copy link
Owner

can't find any documentation anywhere for how to add emissive textures to iris + sodium, are you using a resource pack?

@xdevilkillx
Copy link
Author

I'm not sure, as Complementary Shaders is what give ores Emissive properties, not resource pack.
Sodium is just another Optifine-like performance mod and Iris Shaders just enables Shaders support.

@AstralOrdana
Copy link
Owner

I know what sodium and optifine are, I just don't know where your current emissive ores are coming from so idk how to make mine do the same

@AstralOrdana
Copy link
Owner

idk if its even something I can enable on my end

@xdevilkillx
Copy link
Author

I was just thinking that, might be up to the Complimentary Shaders Devs to do that on their end.
All well, thanks for trying anyways.

@AstralOrdana
Copy link
Owner

No worries, you might be able to ask in their discord how a mod could add emissive compatibility, if you find out any more info, feel free to create a new issue

@xdevilkillx
Copy link
Author

xdevilkillx commented Dec 5, 2021

According to the Discord, there's no way of adding it unless the shader natively supports it.

@K0-RR
Copy link

K0-RR commented Dec 5, 2021

@xdevilkillx
Copy link
Author

No, you don't need shaders for this, you can just use optifine. https://www.curseforge.com/minecraft/texture-packs/emissive-ores-1-17 https://www.planetminecraft.com/texture-pack/neon-ores-hd-1-18-emissive-ores/

Yes, but neither of those affect modded ores. Shaders also add the emissive textures which again, don't affected modded ores unless implemented to do so natively.

I'm not gonna use Optifine anyways because Sodium gives me better performance, 200+FPS with shaders on, while Optifine stays around 70-80 FPS with shaders.

@K0-RR
Copy link

K0-RR commented Dec 5, 2021

This is the official resource pack for BetterNether mod that adds emissive textures to mod's blocks. No idea if there is some code in the mod to make this possible.
https://www.curseforge.com/minecraft/texture-packs/lum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants