Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Switch pyright with basedpyright #1089

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jul 7, 2024

Closes #1055

Copy link

github-actions bot commented Jul 7, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft requested a review from a team July 7, 2024 11:41
@Uzaaft Uzaaft merged commit 77999cc into main Jul 7, 2024
20 checks passed
@Uzaaft Uzaaft deleted the feat/basedpyright branch July 7, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support basedpyright lsp in pack-python.
2 participants