Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editing-support): add true-zen.nvim #223

Merged
merged 1 commit into from
May 25, 2023
Merged

feat(editing-support): add true-zen.nvim #223

merged 1 commit into from
May 25, 2023

Conversation

jay-babu
Copy link
Contributor

No description provided.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🫡

@Uzaaft Uzaaft merged commit 5356792 into AstroNvim:main May 25, 2023
4 checks passed
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wrap the opts here in a function to fix race conditions in code

opts = {
integrations = {
tmux = os.getenv "TMUX" ~= nil, -- hide tmux status bar in (minimalist, ataraxis)
twilight = utils.is_available "twilight.nvim", -- enable twilight (ataraxis)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work necessarily because is_available relies pretty heavily on lazy being done loading. I think this could be resolved by using the function notation for setting opts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants