Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(colorschemes)!: adding mellow, juliana, neosolarized and removing onigiri #238

Merged
merged 2 commits into from
May 28, 2023

Conversation

luxus
Copy link
Member

@luxus luxus commented May 28, 2023

No description provided.

@Uzaaft
Copy link
Member

Uzaaft commented May 28, 2023

@luxus I believe this PR will break some configs, so it should be:
add(colorschemes)!:
cc @mehalter

@luxus
Copy link
Member Author

luxus commented May 28, 2023

Because it removes onigiri? Dunno... if someone uses it :)

@luxus luxus changed the title add(colorschemes): adding mellow, juliana, neosolarized and removing onigiri add(colorscheme): adding mellow, juliana, neosolarized and removing onigiri May 28, 2023
@mehalter mehalter changed the title add(colorscheme): adding mellow, juliana, neosolarized and removing onigiri feat(colorschemes)!: adding mellow, juliana, neosolarized and removing onigiri May 28, 2023
@Uzaaft
Copy link
Member

Uzaaft commented May 28, 2023

Yeah because it removes onigiri, someone might use it, we can't know. Even if it's highly likely that nobody uses it

@mehalter
Copy link
Member

Why was onigiri removed?

@mehalter
Copy link
Member

Can't we just avoid that breaking change and not remove it?

@Uzaaft
Copy link
Member

Uzaaft commented May 28, 2023

Why was onigiri removed?

It's archived by the maintainer.

@mehalter
Copy link
Member

Ok, but it can still be installed. Doesn't seem too bad to just leave it to avoid a breaking change.

@luxus
Copy link
Member Author

luxus commented May 28, 2023

i will do the changes later today

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove onigiri but we could put an archived notice on the README

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and just resolved all of the issues here.

@mehalter mehalter merged commit fbb2327 into main May 28, 2023
4 checks passed
@mehalter mehalter deleted the themes branch May 28, 2023 15:09
mehalter pushed a commit that referenced this pull request May 28, 2023
* fix(neovide): noice and mini.animate is not compatible with neovide

* add(colorschemes): adding mellow, juliana, neosolarized and removing onigiri
Uzaaft pushed a commit that referenced this pull request Jun 11, 2023
* fix(neovide): noice and mini.animate is not compatible with neovide

* add(colorschemes): adding mellow, juliana, neosolarized and removing onigiri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants