fix(java): use stable file locations for JARs provided by mason.nvim #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the introduction of the new registry, packages started linking more than executables (`bin/`) in Mason's root directory. Examples of these are platform-agnostic "share" files, for example the JARs used here. Reaching into the internal package structures of Mason packages is not stable and is prone to break across versions.
|
Note that java-debug-adapter & java-test started linking these files only 3 weeks ago. Users who installed java-debug-adapter or java-test prior to that will not have files at these locations. I'm not sure what the policy is in terms of supported versions, but figured I'd open a PR for awareness anyway |
mehalter
approved these changes
May 31, 2023
Uzaaft
pushed a commit
that referenced
this pull request
Jun 11, 2023
…245) Since the introduction of the new registry, packages started linking more than executables (`bin/`) in Mason's root directory. Examples of these are platform-agnostic "share" files, for example the JARs used here. Reaching into the internal package structures of Mason packages is not stable and is prone to break across versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of the new registry, packages started linking
more than executables (
bin/) in Mason's root directory. Examples ofthese are platform-agnostic "share" files, for example the JARs used
here.
Reaching into the internal package structures of Mason packages is not
stable and is prone to break across versions.