Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): fix null_ls eslint_d registration(s) #274

Merged
merged 3 commits into from
Jun 14, 2023
Merged

fix(typescript): fix null_ls eslint_d registration(s) #274

merged 3 commits into from
Jun 14, 2023

Conversation

rafaelderolez
Copy link
Contributor

@rafaelderolez rafaelderolez commented Jun 13, 2023 •
edited
Loading

  • Removed or not has_prettier from null_ls eslint_d diagnostics registration. Eslint should only be registered if has_eslint returns true. It should not be registered just because a project does not have a prettier config.
  • Added null_ls.builtins.formatting.eslint_d
  • Added null_ls.builtins.code_actions.eslint_d
  • Fixed prettier.config.(c)js filenames

Uzaaft
Uzaaft approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for double checking my work! 🤣

@Uzaaft Uzaaft merged commit 947fbf0 into AstroNvim:main Jun 14, 2023
6 checks passed
@rafaelderolez rafaelderolez deleted the feature/extend-eslint_d-builtins branch June 14, 2023 08:22
@mehalter mehalter mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzaaft Uzaaft Uzaaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafaelderolez @Uzaaft