Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript): Move eslint-lsp to the proper plugin, and add autocmd to format on save #683

Merged
merged 4 commits into from
Dec 15, 2023
Merged

feat(typescript): Move eslint-lsp to the proper plugin, and add autocmd to format on save #683

merged 4 commits into from
Dec 15, 2023

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Dec 13, 2023

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited by mehalter

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member Author

Uzaaft commented Dec 15, 2023

R? @AstroNvim/astrocommunity-maintainers

@Uzaaft @mehalter
Update lua/astrocommunity/pack/typescript/init.lua
8f242bc 
Co-authored-by: Micah Halter <micah@mehalter.com>
mehalter
mehalter requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoopsie

lua/astrocommunity/pack/typescript/init.lua Outdated Show resolved Hide resolved
mehalter
mehalter approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you test it and it works, this looks good to me!

mehalter
mehalter approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bug in insertion. But looks good now

@Uzaaft Uzaaft merged commit dffd674 into main Dec 15, 2023
12 checks passed
@Uzaaft Uzaaft deleted the feat/eslint-on-save branch December 15, 2023 20:06
@Uzaaft Uzaaft mentioned this pull request Dec 15, 2023
Closed
3 tasks
@astronvimbot astronvimbot mentioned this pull request Dec 15, 2023
Merged
Uzaaft added a commit that referenced this pull request Dec 20, 2023
@Uzaaft @mehalter
feat(typescript): Move eslint-lsp to the proper plugin, and add autoc…
bb4e7db 
…md to format on save (#683)

* feat(typescript): Move eslint-lsp to the proper plugin, and add autocmd to format on save

* Update lua/astrocommunity/pack/typescript/init.lua

Co-authored-by: Micah Halter <micah@mehalter.com>

* Update lua/astrocommunity/pack/typescript/init.lua

* Update lua/astrocommunity/pack/typescript/init.lua

---------

Co-authored-by: Micah Halter <micah@mehalter.com>
@Uzaaft Uzaaft mentioned this pull request Mar 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalter mehalter mehalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uzaaft @mehalter