Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): Add missing mode in mapping declerations #720

Merged
merged 9 commits into from
Jan 15, 2024

Conversation

manuuurino
Copy link
Contributor

📑 Description

as title of this pr

Copy link

github-actions bot commented Jan 14, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@manuuurino
Copy link
Contributor Author

There are also some more ive discovered

lua/astrocommunity/color/twilight-nvim/init.lua
lua/astrocommunity/color/vim-highlighter/init.lua
lua/astrocommunity/editing-support/telescope-undo-nvim/init.lua
lua/astrocommunity/editing-support/ultimate-autopair-nvim/init.lua
lua/astrocommunity/file-explorer/mini-files/init.lua
lua/astrocommunity/split-and-window/edgy-nvim/init.lua
lua/astrocommunity/split-and-window/minimap-vim/init.lua

@Uzaaft Uzaaft changed the title fix(oil-nvim): mapping got not registered fix(oil-nvim): Fix bug due to missing mode in mapping decleration Jan 14, 2024
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include all the other instances of the similar error?

mehalter
mehalter previously approved these changes Jan 14, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter dismissed their stale review January 14, 2024 10:28

I can't read sadly

@manuuurino
Copy link
Contributor Author

sure, have thought i would need to do for each file a pr because of the guidelines

@manuuurino
Copy link
Contributor Author

have found also another one

lua/astrocommunity/split-and-window/hop-nvim/init.lua

there are also some plugins that are using the keys option from lazy, it doesnt bring any issues, but is it wanted?

@Uzaaft Uzaaft changed the title fix(oil-nvim): Fix bug due to missing mode in mapping decleration fix(main): Add missing mode in mapping declerations Jan 15, 2024
@Uzaaft Uzaaft merged commit 3f02b06 into AstroNvim:v4 Jan 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants