Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pack): use lsp_opts to get server config for typescript #740

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

tobihans
Copy link
Contributor

馃搼 Description

The typescript packs all-in-one and deno use an incorrect method to get lsp options from AstroLsp. This PR updates them to use the lsp_opts method to get the server configuration.

Copy link

github-actions bot commented Jan 28, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft merged commit d1f52fe into AstroNvim:v4 Jan 29, 2024
12 of 13 checks passed
@tobihans tobihans deleted the fix/ts-pack branch January 29, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants