Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diffview-nvim): use diffview winbar and disable view activation #752

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Feb 6, 2024

📑 Description

This fixes an issue where the default AstroNvim winbar causes rows to be misaligned. This also disables the default view activation so that AstroNvim doesn't try to restore cursor position and fold state when entering buffers.

ℹ Additional Information

Copy link

github-actions bot commented Feb 6, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter requested a review from a team February 6, 2024 11:03
@Uzaaft Uzaaft merged commit a953b0d into main Feb 6, 2024
14 checks passed
@Uzaaft Uzaaft deleted the diffview_opts branch February 6, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants