Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coc): add json for coc configuration #789

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat(coc): add json for coc configuration #789

merged 2 commits into from
Mar 6, 2024

Conversation

wroyca
Copy link
Contributor

@wroyca wroyca commented Mar 6, 2024

馃搼 Description

Pre-install coc-json for Coc configuration, which comes with its own completion source.

Additional Information

image

Copy link

github-actions bot commented Mar 6, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

lua/astrocommunity/lsp/coc-nvim/init.lua Outdated Show resolved Hide resolved
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit b544888 into AstroNvim:feat/coc Mar 6, 2024
10 of 12 checks passed
mehalter added a commit that referenced this pull request Mar 7, 2024
* feat(coc-nvim): add json for coc configuration

* refactor(coc-nvim): configure `coc_global_extensions` in AstroCore

---------

Co-authored-by: Micah Halter <micah@mehalter.com>
mehalter added a commit that referenced this pull request Mar 7, 2024
* feat(coc-nvim): add json for coc configuration

* refactor(coc-nvim): configure `coc_global_extensions` in AstroCore

---------

Co-authored-by: Micah Halter <micah@mehalter.com>
mehalter added a commit that referenced this pull request Mar 7, 2024
* feat(lsp): Add basic coc support

* fix(coc-nvim): Disable more plugins

* feat(coc-nvim): add heirline integration and improve lazy loading

* feat(coc-nvim): start adding coc mappings

* chore: remove AstroLSP

* docs(coc-nvim): add README

* feat(coc-nvim): add json for coc configuration (#789)

* feat(coc-nvim): add json for coc configuration

* refactor(coc-nvim): configure `coc_global_extensions` in AstroCore

---------

Co-authored-by: Micah Halter <micah@mehalter.com>

* feat(coc-nvim): add v-mode selection format (#787)

* feat(coc-nvim): add marketplace (#788)

* fix(coc-nvim): force statusline redraw

* chore(coc-nvim): normalize command calls

* feat(coc-nvim): add service to statusbar

Co-authored-by: William Roy <wroy@proton.me>

* feat(coc-nvim): add extension for telescope.nvim (#792)

Co-authored-by: Micah Halter <micah@mehalter.com>

* fix(coc-nvim): default `cmdheight=1` when using coc-nvim

* fix(coc-nvim): disable `foldcolumn` for coc lists

* chore(coc-nvim): clean up heirline callbacks

* feat(coc-nvim): add more missing LSP mappings

* chore(coc-nvim): clean up package disabling to only core plugins

---------

Co-authored-by: Uzair Aftab <uzaaft@outlook.com>
Co-authored-by: William Roy <wroy@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants