Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coq_nvim): fix coq bindings #798

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

tku137
Copy link
Contributor

@tku137 tku137 commented Mar 10, 2024

馃搼 Description

After coq is lazy loaded, meaning after the first autocompletion is triggered, it's default binding <C-h> for jump_to_mark (https://github.com/ms-jpq/coq_nvim/blob/coq/docs/SNIPS.md#snippets) clashes with AstroNVims window movement. Basically, as soon as coq is loaded, you can't switch to the left window anymore.

This is an attempt to fix that. I chose <C-t> to jump to the next snippet edit, which is absolutely a debatable choice. I think this clashes the least with both AstroNVims and Neovims default bindings.

Copy link

github-actions bot commented Mar 10, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented Mar 11, 2024

@tku137 We use in astronvim, so i think we should use the same key here.

@tku137
Copy link
Contributor Author

tku137 commented Mar 12, 2024

@Uzaaft sorry I can't follow. What do we use in astronvim? <C-H> is astronvims "move to left split. But this gets overwritten as soon as coq is loaded, because <C-H> is coq's default "jump to mark" binding. Instead of changing astronvim's split movement, I suggest to change coq's jump to mark here.

@Uzaaft
Copy link
Member

Uzaaft commented Mar 12, 2024

@Uzaaft sorry I can't follow. What do we use in astronvim? <C-H> is astronvims "move to left split. But this gets overwritten as soon as coq is loaded, because <C-H> is coq's default "jump to mark" binding. Instead of changing astronvim's split movement, I suggest to change coq's jump to mark here.

Lol my message was written in haste.
In astronvim, we use tab to jump to the next node in a snippet. We should use the same here.

@tku137
Copy link
Contributor Author

tku137 commented Mar 16, 2024

Good point, thanks. I just changed it.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 1cbd1cf into AstroNvim:v4 Mar 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants