Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keybinding): Add mini.clue #801

Merged
merged 5 commits into from
Mar 19, 2024
Merged

feat(keybinding): Add mini.clue #801

merged 5 commits into from
Mar 19, 2024

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Mar 13, 2024

📑 Description

ℹ Additional Information

Copy link

github-actions bot commented Mar 13, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the base branch from main to v4 March 13, 2024 21:12
@Uzaaft Uzaaft changed the title Feat/miniclue feat(keybinding): Add mini.clue Mar 13, 2024
@luxus
Copy link
Member

luxus commented Mar 13, 2024

the implementation of the which_key_queue is nice.

@Uzaaft Uzaaft marked this pull request as ready for review March 19, 2024 16:33
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Formatting needs to be fixed
  2. Keys for lazy loading don't seem correct. There are a lot more triggers than just <Leader>

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 632e3b7 into v4 Mar 19, 2024
11 of 12 checks passed
@mehalter mehalter deleted the feat/miniclue branch March 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants