Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neorg)!: fix breaking change in v8.0.0 #813

Merged
merged 6 commits into from
Mar 30, 2024

Conversation

ALVAROPING1
Copy link
Contributor

📑 Description

Neorg recently released version 8.0.0 with a breaking change that requires slightly changing the config. This PR applies the necessary changes to get the plugin working correctly again. This is a breaking change because it requires a couple new system dependencies: Lua 5.1/LuaJIT and the Lua header files.

ℹ Additional Information

Neorg now includes a build.lua file to handle the build process. The old build step specified with build is no longer sufficient, so specifying it leads to a broken installation as it overrides the included build.lua script.

Neorg now uses luarocks to manage its own dependencies, which is automatically compiled and installed by the luarocks.nvim plugin dependency using a system installation of Lua 5.1/LuaJIT with the Lua header files.

Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented Mar 25, 2024

See #634.

@Uzaaft Uzaaft marked this pull request as draft March 25, 2024 14:14
@Uzaaft Uzaaft changed the base branch from main to v4 March 25, 2024 14:38
@Uzaaft
Copy link
Member

Uzaaft commented Mar 25, 2024

Changed target branch to v4.
@ALVAROPING1 Are you running v4 or v3 of astronvim?

@ALVAROPING1
Copy link
Contributor Author

ALVAROPING1 commented Mar 25, 2024

Changed target branch to v4. @ALVAROPING1 Are you running v4 or v3 of astronvim?

I'm running v3 of astronvim currently. If this is going to be postponed until after v4 is released, it might be worth it to pin neorg's version to its last commit before the recent changes (583a82e) as a temp fix, since otherwise this spec won't work with neorg's latest commit

@Uzaaft
Copy link
Member

Uzaaft commented Mar 25, 2024

Changed target branch to v4. @ALVAROPING1 Are you running v4 or v3 of astronvim?

I'm running v3 of astronvim currently. If this is going to be postponed until after v4 is released, it might be worth it to pin neorg's version to its last commit before the recent changes (583a82e) as a temp fix, since otherwise this spec won't work with neorg's latest commit

Sure, sounds like a plan. I'll do that in v4 then. The v3 branch is frozen until then

@Uzaaft Uzaaft merged commit 34a09c9 into AstroNvim:v4 Mar 30, 2024
8 of 9 checks passed
@ALVAROPING1 ALVAROPING1 deleted the fix-neorg branch March 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants