Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts-error-translator-nvim): svelte and astro support added #827

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Apr 4, 2024

📑 Description

The Svelte and Astro language servers are running tsserver under the hood so we should also enable this when svelte support gets added to ts-error-transltor.nvim.

Dependent on: dmmulroy/ts-error-translator.nvim#26

ℹ Additional Information

Copy link

github-actions bot commented Apr 4, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter changed the title feat(ts-error-translator-nvim): svelte support added feat(ts-error-translator-nvim): svelte and astro support added Apr 4, 2024
@mehalter mehalter marked this pull request as ready for review April 4, 2024 22:23
@mehalter mehalter requested a review from a team April 4, 2024 22:24
@mehalter mehalter merged commit b1e5f08 into main Apr 4, 2024
19 checks passed
@mehalter mehalter deleted the svelte_ts_error_translator branch April 4, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant