Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editing-support): add nvim-context-vt #858

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

manuuurino
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Apr 9, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmd should be added

Uzaaft
Uzaaft previously approved these changes Apr 9, 2024
@Uzaaft Uzaaft dismissed their stale review April 9, 2024 19:56

wrong plugin directory

@Uzaaft
Copy link
Member

Uzaaft commented Apr 9, 2024

@manuuurino This plugin should be in editing-support imo.

@manuuurino manuuurino changed the title feat(lsp): add nvim-context-vt feat(editing-support): add nvim-context-vt Apr 9, 2024
@mehalter mehalter merged commit bfd2058 into AstroNvim:main Apr 10, 2024
15 checks passed
This was referenced Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants