Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): improve prettier detection with astrocore.rooter #960

Merged
merged 2 commits into from
May 14, 2024

Conversation

mehalter
Copy link
Member

📑 Description

This leverages AstroCore's built in rooter module to improve the prettier detection. It will search up to detect prettier configuration files moving up the filesystem to handle being inside a nested folder. This also adds LSP integration by checking for package.json files inside of all LSP working directories along with the current directory

ℹ Additional Information

Copy link

github-actions bot commented May 13, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter merged commit 3f9e967 into main May 14, 2024
12 checks passed
@mehalter mehalter deleted the better_prettier_detection branch May 14, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant