Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify internal logic #1

Open
Gummibeer opened this issue Mar 4, 2021 · 0 comments
Open

Simplify internal logic #1

Gummibeer opened this issue Mar 4, 2021 · 0 comments

Comments

@Gummibeer
Copy link
Member

The current code is relatively complex and in turn doesn't allow all TTL values the underlying Cache::remember() accepts.
This should be changed so the packages trait is primary/only responsible to automatically create the cache key, add the alias methods remember() ... to the model itself and pass everything else to the cache method and let it validate them.

As we are pre-v1 the changes can be breaking (like removing type-hints).

@Gummibeer Gummibeer changed the title Simply internal logic Simplify internal logic Mar 4, 2021
@Gummibeer Gummibeer self-assigned this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant