Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Change Requests #1

Closed
cbl opened this issue Apr 22, 2021 · 1 comment · Fixed by #2
Closed

Change Requests #1

cbl opened this issue Apr 22, 2021 · 1 comment · Fixed by #2
Assignees

Comments

@cbl
Copy link
Contributor

cbl commented Apr 22, 2021

I have some improvement Ideas that I think would be great.

  1. Changing Concerns folder name to Traits.

The Concerns folder are used by Laravel for traits that should not be used outside of the package/component, so concerning classes within the package/component. And Traits are meant to be used outside of the package. (Please correct me if I'm wrong)

  1. Changing the Fileable trait name to HasFiles.

Renaming the trait to HasFiles has the benefit that no alias has to be created since the contract is named the same.

@Gummibeer
Copy link
Member

There isn't a fully consistent rule about concerns in Laravel \App\Eloquent\Concerns\Authorizable for example.
And I use that namespace for all packages as it makes it clear that these are traits. I think that isn't worth a breaking release. And even if the renaming enforces a breaking release I would still want to keep the namespace part in case there are more traits in the future.

The Fileable trait renaming is a valid point and I would accept a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants