Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded locale key in Relationship trait #145

Closed
nedix opened this issue Apr 23, 2020 · 1 comment · Fixed by #146
Closed

Hardcoded locale key in Relationship trait #145

nedix opened this issue Apr 23, 2020 · 1 comment · Fixed by #146
Assignees
@Gummibeer
Labels
bug

Comments

@nedix
Copy link

nedix commented Apr 23, 2020

Describe the bug
The Relationship trait makes use of hardcoded locale keys in the translation and localeOrFallback methods.

To Reproduce
Use a foreign key other than locale on your translations table to reference the languages table.

Expected behavior
The locale_key configuration value to be used in the query.

Versions

  • Package: 11.8

Exception
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'locale' in 'where clause'
@nedix nedix added the bug label Apr 23, 2020
@Gummibeer Gummibeer self-assigned this Apr 23, 2020
@Gummibeer Gummibeer mentioned this issue Apr 23, 2020
Merged
@Gummibeer
Copy link
Member

Hey,
thanks for reporting.
It's fixed in v11.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gummibeer Gummibeer

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix hardcoded locale column name Astrotomic/laravel-translatable
2 participants
@nedix @Gummibeer