Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception in server #80

Open
AsturaPhoenix opened this issue Jul 31, 2023 · 1 comment
Open

Uncaught exception in server #80

AsturaPhoenix opened this issue Jul 31, 2023 · 1 comment
Assignees
Labels
a:server Aggregation server bug Something isn't working

Comments

@AsturaPhoenix
Copy link
Owner

AsturaPhoenix commented Jul 31, 2023

This exception is eventually caught, but we probably don't register an error handler early enough for Dart to consider the error caught. This is probably a future in a cache. The traces weren't particularly useful; one instance was an http.ClientException from interleave2x32.

In the error logs:

[2023-07-30 01:40:03.554665Z] WARNING AquamarineServer: Failed to fetch f025.20230729.t21z
        Connection closed while receiving data
#0      IOClient.send.<anonymous closure> (package:http/src/io_client.dart:82:13)
#1      Stream.handleError.<anonymous closure> (dart:async/stream.dart:923:16)

This probably only impacts running in debug mode, where the VM stops on uncaught asynchronous exceptions.

@AsturaPhoenix AsturaPhoenix added bug Something isn't working a:server Aggregation server labels Jul 31, 2023
@AsturaPhoenix AsturaPhoenix self-assigned this Aug 2, 2023
@AsturaPhoenix
Copy link
Owner Author

This is probably spurious. Tests of this test case do not complain of an uncaught exception unless observatory is attached, so this is likely related to dart-lang/sdk#47985 and friends. That is to say, the uncaught exception handler for the test zone is never invoked; only the debugger complains. I suspect the latter is using less robust/correct logic to determine whether an exception is caught.

Will close this issue after committing a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:server Aggregation server bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant