Feat/new resources #17
Conversation
BREAKING CHANGE: New resources contain new dependencies. One of these contains graphql which may require you to delete and reinstall node modules. We have updated several versions so when updating, you should rerun yarn install and may need to remove node_modules before hand.
|
Could we get this PR merged :) would be nice to have it working. |
|
@sureshHARDIYA Unfortunately this is probably not going to happen today. Since this PR is so large it is going to take some time to verify things are working the way we want and the newly generated code does not reintroduce old bugs. We have unit tests and some basic integration tests to verify the code runs fine, but we need to go through and try to make sure things are conformant. Once @jonterrylee and myself have had a chance to go over all this in detail and feel this is not a regression in any sense, we will get it merged. If you really need to use this you can check out this branch, |
|
@Robert-W thank you for notifying. I will check out |
| * SIMPLE FEATURE FLAGS. SECRETS SHOULD BE PART OF YOUR DEPLOYMENT STRATEGY | ||
| */ | ||
|
|
||
| if (process.env.NODE_ENV === 'development') { |
There was a problem hiding this comment.
is there a need for defaults?
There was a problem hiding this comment.
Nope, the defaults are already assumed in @asymmetrik/sof-graphql-invariant. Smart on FHIR auth is enabled by default and GraphiQL will also require auth. These are basically just feature flags to control that behavior.
This PR makes the following changes:
@asymmetrik/sof-graphql-invariantfor cleaner Smart on FHIR supportBREAKING CHANGES (Listed in CHANGELOG.md):
@asymmetrik/sof-graphql-invariantdepends on a newer version of GraphQL than what was used. GraphQL has been updated here but when upgrading, users may need to removenode_modulesand reinstall. They will need to runyarn installregardless since we added new dependencies.