Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sof strategy #22

Merged
merged 5 commits into from Feb 8, 2019
Merged

Feat/sof strategy #22

merged 5 commits into from Feb 8, 2019

Conversation

Robert-W
Copy link
Contributor

@Robert-W Robert-W commented Feb 4, 2019

This does contain a potentially breaking change, which is that the authentication no longer requires a url to a strategy, which was a little confusing when strategy was in node modules. It now accepts the strategy as a module. To enable authentication, they must provide the same environment variables in the same manner, it is only breaking in the sense they need to rerun npm install when upgrading since their is a new dependency or if they added their own strategy.

Robert Winterbottom added 5 commits January 8, 2019 13:15
@Robert-W Robert-W added the enhancement New feature or request label Feb 4, 2019
@Robert-W Robert-W self-assigned this Feb 4, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 96

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 90: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 96

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 90: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

@Robert-W Robert-W merged commit 41e37c1 into master Feb 8, 2019
@Robert-W Robert-W deleted the feat/sof-strategy branch February 8, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants