Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

Enable Karma Test #29

Merged
merged 1 commit into from Dec 19, 2016
Merged

Enable Karma Test #29

merged 1 commit into from Dec 19, 2016

Conversation

bodnarbm
Copy link
Contributor

No description provided.

@brianghig
Copy link
Contributor

@bodnarbm changes look good! Are we waiting on reporting the results of the karma UI tests for a future PR, or should that be available here?

@bodnarbm
Copy link
Contributor Author

@brianghig I updated the PR with two changes.

  1. Worked around a bug in karma that results in a significant delay (~30 seconds) in ending the process. The workaround involves calling karma as a child process and waiting for it to end.

  2. Added mocha style reporting for the test output.

Not sure if this resolves your prior comment on reporting the results of the karma test.

Eventually we should add code coverage reporting for the karma test also.

@brianghig
Copy link
Contributor

@bodnarbm I still need to pull this locally to check it out, but did that second commit make it into this PR? I'm still only seeing the one...

@bodnarbm
Copy link
Contributor Author

@brianghig The second commit was squashed into the first.

@brianghig brianghig merged commit 8a71957 into bluehalo:staging Dec 19, 2016
@bodnarbm bodnarbm deleted the feature/enable-karma branch December 19, 2016 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants