Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add token searching for psql #32

Merged
merged 2 commits into from
Nov 12, 2019
Merged

feat: add token searching for psql #32

merged 2 commits into from
Nov 12, 2019

Conversation

zeevo
Copy link
Collaborator

@zeevo zeevo commented Nov 8, 2019

The biggest change here is creating a distinction between "normal matches" and "token matches" to give fhir-qb-sql and other implementations the flexibility to handle these differently

sshah-asymmetrik
sshah-asymmetrik approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@sshah-asymmetrik sshah-asymmetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Go ahead and merge. We lost a little bit of coverage on qb-sql and qb-mongo, but we'll make that a separate pr when there's more time.

@sshah-asymmetrik sshah-asymmetrik merged commit b9222d4 into master Nov 12, 2019
@zeevo zeevo deleted the feat/add-token-searching branch November 12, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshah-asymmetrik sshah-asymmetrik sshah-asymmetrik approved these changes

@jonterrylee jonterrylee Awaiting requested review from jonterrylee jonterrylee is a code owner

@Robert-W Robert-W Awaiting requested review from Robert-W

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeevo @sshah-asymmetrik