Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators: handle errors in other for withLatestFrom #14

Merged
merged 1 commit into from Mar 13, 2022

Conversation

twittemb
Copy link
Contributor

Description

This PR improves the error management for withLatestFrom when the other sequence fails.

Checklist

  • this PR is based on the main branch and is up-to-date, if not please rebase your branch on the top of main
  • the commits inside this PR have explicit commit messages
  • unit tests cover the new feature or the bug fix
  • the feature is documented in the README.md if it makes sense
  • the CHANGELOG is up-to-date

@twittemb twittemb force-pushed the improve/handle-error-withLatestFrom branch from effabcd to 3c41837 Compare March 13, 2022 12:35
@twittemb twittemb force-pushed the improve/handle-error-withLatestFrom branch from 3c41837 to db10b3f Compare March 13, 2022 16:24
@codecov-commenter
Copy link

Codecov Report

Merging #14 (db10b3f) into main (0aafcc4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   97.49%   97.49%   -0.01%     
==========================================
  Files          50       50              
  Lines        2433     2471      +38     
==========================================
+ Hits         2372     2409      +37     
- Misses         61       62       +1     
Impacted Files Coverage Δ
...urces/Operators/AsyncSequence+SwitchToLatest.swift 100.00% <ø> (ø)
...urces/Operators/AsyncSequence+WithLatestFrom.swift 100.00% <100.00%> (ø)
.../Operators/AsyncSequence+WithLatestFromTests.swift 100.00% <100.00%> (ø)
.../Operators/AsyncSequence+SwitchToLatestTests.swift 94.11% <0.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aafcc4...db10b3f. Read the comment docs.

@twittemb twittemb merged commit 6d3d520 into main Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants