nit

AsyncHttpClient · Mar 19, 2018 · 420b017 · 420b017
1 parent 5f448ed
commit 420b017
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/client/src/main/java/org/asynchttpclient/netty/request/NettyRequestFactory.java b/client/src/main/java/org/asynchttpclient/netty/request/NettyRequestFactory.java
@@ -39,8 +39,6 @@
 
 public final class NettyRequestFactory {
 
-  private static final String BROTLY_ACCEPT_ENCODING_SUFFIX = ", br";
-  private static final String GZIP_DEFLATE = HttpHeaderValues.GZIP + "," + HttpHeaderValues.DEFLATE;
   private static final Integer ZERO_CONTENT_LENGTH = 0;
 
   private final AsyncHttpClientConfig config;
@@ -154,9 +152,7 @@ public NettyRequest newNettyRequest(Request request, boolean performConnectReque
       String userDefinedAcceptEncoding = headers.get(ACCEPT_ENCODING);
       if (userDefinedAcceptEncoding != null) {
         // we don't support Brotly ATM
-        if (userDefinedAcceptEncoding.endsWith(BROTLY_ACCEPT_ENCODING_SUFFIX)) {
+        headers.set(ACCEPT_ENCODING, filterOutBrotliFromAcceptEncoding(userDefinedAcceptEncoding));
-          headers.set(ACCEPT_ENCODING, userDefinedAcceptEncoding.subSequence(0, userDefinedAcceptEncoding.length() - BROTLY_ACCEPT_ENCODING_SUFFIX.length()));
-        }
 
       } else if (config.isCompressionEnforced()) {
         headers.set(ACCEPT_ENCODING, GZIP_DEFLATE);
@@ -211,7 +207,7 @@ public NettyRequest newNettyRequest(Request request, boolean performConnectReque
 
     // Add default accept headers
     if (!headers.contains(ACCEPT)) {
-      headers.set(ACCEPT, "*/*");
+      headers.set(ACCEPT, ACCEPT_ALL_HEADER_VALUE);
     }
 
     // Add default user agent

diff --git a/client/src/main/java/org/asynchttpclient/util/HttpUtils.java b/client/src/main/java/org/asynchttpclient/util/HttpUtils.java
@@ -12,6 +12,8 @@
  */
 package org.asynchttpclient.util;
 
+import io.netty.handler.codec.http.HttpHeaderValues;
+import io.netty.util.AsciiString;
 import org.asynchttpclient.AsyncHttpClientConfig;
 import org.asynchttpclient.Param;
 import org.asynchttpclient.Request;
@@ -32,10 +34,16 @@
  */
 public class HttpUtils {
 
+  public static final AsciiString ACCEPT_ALL_HEADER_VALUE = new AsciiString("*/*");
+
+  public static final AsciiString GZIP_DEFLATE = new AsciiString(HttpHeaderValues.GZIP + "," + HttpHeaderValues.DEFLATE);
+
   private static final String CONTENT_TYPE_CHARSET_ATTRIBUTE = "charset=";
 
   private static final String CONTENT_TYPE_BOUNDARY_ATTRIBUTE = "boundary=";
 
+  private static final String BROTLY_ACCEPT_ENCODING_SUFFIX = ", br";
+
   private HttpUtils() {
   }
 
@@ -194,4 +202,12 @@ private static void encodeAndAppendFormField(StringBuilder sb, String field, Cha
       }
     }
   }
+
+  public static CharSequence filterOutBrotliFromAcceptEncoding(String acceptEncoding) {
+    // we don't support Brotly ATM
+    if (acceptEncoding.endsWith(BROTLY_ACCEPT_ENCODING_SUFFIX)) {
+      return acceptEncoding.subSequence(0, acceptEncoding.length() - BROTLY_ACCEPT_ENCODING_SUFFIX.length());
+    }
+    return acceptEncoding;
+  }
 }