Speed up ChannelPool offering

AsyncHttpClient · Jan 4, 2016 · e7798c8 · e7798c8
1 parent 3d5a253
commit e7798c8
Showing 1 changed file with 20 additions and 5 deletions.
diff --git a/client/src/main/java/org/asynchttpclient/netty/channel/DefaultChannelPool.java b/client/src/main/java/org/asynchttpclient/netty/channel/DefaultChannelPool.java
@@ -243,13 +243,28 @@ public boolean offer(Channel channel, Object partitionKey) {
         if (isTtlExpired(channel, now))
             return false;
 
-        boolean added = partitions.computeIfAbsent(partitionKey, pk -> new ConcurrentLinkedQueue<>()).add(new IdleChannel(channel, now));
+        boolean offered = offer0(channel, partitionKey,now);
-        if (added)
+        if (offered) {
-            channelId2Creation.putIfAbsent(channelId(channel), new ChannelCreation(now, partitionKey));
+            registerChannelCreation(channel, partitionKey, now);
+        }
 
-        return added;
+        return offered;
     }
-
+
+    private boolean offer0(Channel channel, Object partitionKey, long now) {
+        ConcurrentLinkedQueue<IdleChannel> partition = partitions.get(partitionKey);
+        if (partition == null) {
+            partition = partitions.computeIfAbsent(partitionKey, pk -> new ConcurrentLinkedQueue<>());
+        }
+        return partition.add(new IdleChannel(channel, now));
+    }
+
+    private void registerChannelCreation(Channel channel, Object partitionKey, long now) {
+        if (channelId2Creation.containsKey(partitionKey)) {
+            channelId2Creation.putIfAbsent(channelId(channel), new ChannelCreation(now, partitionKey));
+        }
+    }
+
     /**
      * {@inheritDoc}
      */